[llvm-commits] compiler-rt asan on FreeBSD

[Kostya Serebryany]

On Tue, Aug 21, 2012 at 1:03 PM, Evgeniy Stepanov <eugenis at google.com>wrote:

>
>
>
> On Tue, Aug 21, 2012 at 10:14 AM, Kostya Serebryany <kcc at google.com>wrote:
>
>> Hi Dan,
>>
>> I am very glad that you doing this!
>> However, adding a new platform which my team is not supporting will cause
>> some amount of pain.
>> Do you plan to have a public buildbot for LLVM+asan on FreeBSD?
>>
>> While my team is the only party maintaining asan, our private bots work
>> fine,
>> but once others start adding more platforms to asan we will need public
>> bots.
>> Chandler, all, is there any chance to have public bots for asan (Linux,
>> Mac, Android, Win32, FreeBSD) somewhere?
>>
>
>>
>> +#if !defined(__linux__) && !defined(__APPLE__) && !defined(_WIN32) &&
>> !defined(__FreeBSD__)
>>
>> Please honor 80-chars-per-line rule
>>
>> -  return syscall(__NR_munmap, addr, length);
>>
>>
>> +  return syscall(SYS_munmap, addr, length);
>>
>> My recollection is that this will not work for Android.
>>
>
> Yes, Android only has _NR_*, and not SYS_*.
>
>
>> Evgeniy?
>>
>> Maybe it makes sense to create sanitizer_common/sanitizer_bsd.cc
>> (or sanitizer_freebsd.cc)?
>> OTOH, most of the code will be the same...
>>
>
> I guess the difference from linux will be minimal. Better add a few
> #ifdefs.
>

Maybe define some macro like
  SYSCALL_NAME(name) which will expand into either __NR_#name or SYS_#name?



--kcc



>
>
>>
>>
>> --kcc
>>
>>
>> On Tue, Aug 21, 2012 at 8:54 AM, Dan McGregor <danismostlikely at gmail.com>wrote:
>>
>>> Hello,
>>>
>>> Over the last few days I've been working on getting ASan working on
>>> FreeBSD.  My ongoing work can be seen at
>>> https://github.com/dannomac/compiler-rt/tree/freebsd.  Here is a patch
>>> to get ASan building on FreeBSD 10, though i386 on amd64 builds currently
>>> don't work amd64 builds do.
>>>
>>> Dan
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120821/c9789b1f/attachment.html>