[llvm-commits] [llvm] r162034 - /llvm/trunk/include/llvm/Object/ELF.h

[Rafael Espíndola]

On 16 August 2012 14:33, Chandler Carruth <chandlerc at google.com> wrote:
> Test cases?

We discussed this a bit on IRC. It is my impression that we already
went too far with PPC ELF without testing. As Roman itself noticed two
days ago, it is possible to break hello word on ppc elf and not notice
it:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120813/148239.html

We have been too slow to add tests, even when we noticed that entire
functions could be deleted and the tests would still pass:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20111219/133931.html
(which btw, is still the case on trunk).

So sorry for the current state for those starting to hack now on pcc
elf, but to make sure we are in a better position tomorrow I think we
have to start requiring tests as features are added and hopefully also
cover the backlog we have so far.

Cheers,
Rafael