[llvm-commits] [LNT] r161838 - /lnt/trunk/lnt/server/ui/views.py

[Daniel Dunbar]

On Mon, Aug 13, 2012 at 9:20 PM, Michael Gottesman <mgottesman at apple.com> wrote:
> Author: mgottesman
> Date: Mon Aug 13 23:20:57 2012
> New Revision: 161838
>
> URL: http://llvm.org/viewvc/llvm-project?rev=161838&view=rev
> Log:
> [LNT] v4_global_status: Added current settings control panel.
>
> *NOTE* Baseline Type and Baseline Date in this commit are just set to None.
> I will put in support for those two features in a later commit.

This seems like an overly fine granularity to commit at. I'm fine
having partially implemented features, but I don't like having "dead"
code in the code base. This should be merged with subsequent patches
or eliminated.

 - Daniel

> Modified:
>     lnt/trunk/lnt/server/ui/views.py
>
> Modified: lnt/trunk/lnt/server/ui/views.py
> URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/ui/views.py?rev=161838&r1=161837&r2=161838&view=diff
> ==============================================================================
> --- lnt/trunk/lnt/server/ui/views.py (original)
> +++ lnt/trunk/lnt/server/ui/views.py Mon Aug 13 23:20:57 2012
> @@ -740,14 +740,20 @@
>
>      # Order the table by worst regression.
>      test_table.sort(key = lambda row: row[1], reverse=True)
> -
> +
> +    baselinetype = None
> +    date = None
> +
>      return render_template("v4_global_status.html",
>                             ts=ts,
>                             tests=test_table,
>                             machines=recent_machines,
>                             machine_groups_map=machine_groups_map,
>                             groups = list(grouping_set),
> -                           selected_field=field)
> +                           selected_field=field,
> +                           selected_baselinetype=baselinetype,
> +                           selected_revision=revision,
> +                           selected_date=date)
>
>  @v4_route("/daily_report/<int:year>/<int:month>/<int:day>")
>  def v4_daily_report(year, month, day):
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits