[llvm-commits] [llvm] r161979 - /llvm/trunk/unittests/Support/Path.cpp

[Peter Cooper]

On Aug 15, 2012, at 2:15 PM, Michael Spencer <bigcheesegs at gmail.com> wrote:

> On Wed, Aug 15, 2012 at 1:35 PM, Peter Cooper <peter_cooper at apple.com> wrote:
>> Hi Michael
>> 
>> We had a buildbot failure with this code (or the previous commits).  Does
>> this fix it?
> 
> Yes, sorry for the breakage.
No problem.  The buildbot recovered very quickly.  Thanks for fixing it so fast.

Pete
> 
> - Michael Spencer
> 
>> 
>> The error is
>> 
>> llvm/unittests/Support/Path.cpp:386:26: error: calling a private constructor
>> of class 'llvm::sys::fs::mapped_file_region'
>>  fs::mapped_file_region mfrrv(llvm_move(m));
>>                         ^
>> llvm/include/llvm/Support/FileSystem.h:584:3: note: implicitly declared
>> private here
>>  mapped_file_region(mapped_file_region&) LLVM_DELETED_FUNCTION;
>>  ^
>> 1 error generated.
>> 
>> 
>> 
>> Thanks,
>> Pete
>> 
>> On Aug 15, 2012, at 12:21 PM, Michael J. Spencer <bigcheesegs at gmail.com>
>> wrote:
>> 
>> Author: mspencer
>> Date: Wed Aug 15 14:21:42 2012
>> New Revision: 161979
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=161979&view=rev
>> Log:
>> Properly test the LLVM_USE_RVALUE_REFERENCES macro.
>> 
>> Modified:
>>   llvm/trunk/unittests/Support/Path.cpp
>> 
>> Modified: llvm/trunk/unittests/Support/Path.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/Path.cpp?rev=161979&r1=161978&r2=161979&view=diff
>> ==============================================================================
>> --- llvm/trunk/unittests/Support/Path.cpp (original)
>> +++ llvm/trunk/unittests/Support/Path.cpp Wed Aug 15 14:21:42 2012
>> @@ -375,7 +375,7 @@
>> 
>>  // Unmap temp file
>> 
>> -#ifdef LLVM_USE_RVALUE_REFERENCES
>> +#if LLVM_USE_RVALUE_REFERENCES
>>  fs::mapped_file_region m(Twine(TempPath),
>>                             fs::mapped_file_region::readonly,
>>                             0,
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>>