[llvm-commits] [PATCH] Fix bug with _MSC_VER define

[John Garvin]

It's not strictly necessary, but it would allow compiling with -Werror -Wundef.

John

On Aug 14, 2012, at 10:17 PM, Chris Lattner wrote:

> 
> On Aug 14, 2012, at 4:19 PM, John Garvin <jgarvin at apple.com> wrote:
> 
>> Support/Compiler.h was asking about the value of _MSC_VER without making sure it was defined first. Please review.
> 
> The patch isn't necessarily wrong, but why is it needed?  Use of undefined macros is specified to yield 0 by the C preprocessor.  I don't understand what this patch changes or fixes.
> 
> -Chris