[llvm-commits] [PATCH, Hexagon]: Remove unnecessary saves and restores to and from the stack in leaf functions.

[Arnold Schwaighofer]

I'll commit it for you.

On 8/13/2012 11:08 AM, Pranav Bhandarkar wrote:
> Can somebody with rights to review/approve a Hexagon backend patch please
> review it, so that persons with commit-after-approval rights to the Hexagon
> backend can commit it.
>
> Thanks,
> Pranav
>
>> -----Original Message-----
>> From: Arnold Schwaighofer [mailto:arnolds at codeaurora.org]
>> Sent: Friday, August 10, 2012 6:25 PM
>> To: Pranav Bhandarkar
>> Cc: llvm-commits at cs.uiuc.edu
>> Subject: Re: [llvm-commits] [PATCH, Hexagon]: Remove unnecessary saves
>> and restores to and from the stack in leaf functions.
>>
>> LGTM.
>>
>>
>>> Hi,
>>>
>>> This is a fix for PR-13572 (http://llvm.org/bugs/show_bug.cgi?id=13572).
>>>
>>> HexagonInstrInfo.td wrongly encoded that register pairs D0 through
>>> D10, R22, R23, R28, R31 and the predicate registers were clobbered by
>>> a tail call  instruction. So if a function turned into a leaf function
>>> on account of a call being converted into a tail call (jump), the
>>> caller-save registers would still get saved on the stack and restored
>>> from it, quite unnecessarily.
>>>
>>> The attached patch fixes this problem. I have tested that it builds
>>> and installs and have also run make check without any regressions with
>>> this patch.
>>>
>>> Pranav
>>>
>>> Qualcomm Innovation Center (QuIC) is a member of the Code Aurora
>> Forum.
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>>
>> --
>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum.
>
>



-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum.