[llvm-commits] [PATCH] Add support for fast calling convention

Renato Golin rengolin at systemcall.org
Fri Aug 10 03:21:24 PDT 2012


On 10 August 2012 04:49, Jush Lu <jush.msn at gmail.com> wrote:
> This part doesn’t fix anything, it just simplifies if statements, no
> functionality changes in this part.

I think this is an even bigger reason to split the patch.

The fix should be minimalistic and have all possible tests associated,
to make it easier to roll-back, further analyse and to know what that
patch was intended to fix in the first place, say, an year from now.

It doesn't matter much if you want to submit the fix first or the
clean up first. Clean-ups also generally don't need additional tests.

-- 
cheers,
--renato

http://systemcall.org/




More information about the llvm-commits mailing list