[llvm-commits] [PATCH] Review request: Allow assembly macro parameters and arguments delimited by spaces

[Rafael Espíndola]

On 2 August 2012 17:40, Zhang, Andy <andy.zhang at intel.com> wrote:
> Hi all,
>
> I have combined PaX Team's patch with mine, attached to this message. This patch adds support for delimiting assembly macro parameters and arguments with spaces to improve compatibility with GNU as, and fixes a bug where underscores in macro parameters were not recognized.
>
> It also includes all of PaX Team's changes for macro handling (arguments in .irpc and .irp, improved error messages for macro arguments, default parameter values, nested macros) and fixes the assertion failures in that patch. There are also updated test cases.

Thanks for combining the patches! I was finding the patch a bit noisy,
so I have extracted and committed the typedefs and the I have update
this patch to keep using raw_svector_ostream.

> Please review and let me know if it is ok to commit.

I cannot review it right now, but lets see if someone else takes it.
If not, ping me in a week and I will try to take a look.

> Thanks,
> Andy
>

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: asm.patch
Type: application/octet-stream
Size: 21479 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120808/4ec5fb15/attachment.obj>