[llvm-commits] [PATCH] Remove unneeded and unused OpenBSD defines

[Bill Wendling]

LGTM.

-bw

On Aug 7, 2012, at 8:52 PM, David Hill <dhill at mindcry.org> wrote:

> Ping.
> 
> On Tue, Aug 07, 2012 at 03:24:24PM -0400, David Hill wrote:
>> Hello,
>> 
>> Attached is a diff that removes OpenBSD defines.
>> - The defines are in stddint.h, which is #include'd already.
>> - The block wasn't used anyway, since it was _OpenBSD_, and not
>> __OpenBSD__
>> 
>> Please review and commit.
>> 
>> Thanks,
>> David
>> 
> 
>> diff --git a/include/llvm/Support/DataTypes.h.cmake b/include/llvm/Support/DataTypes.h.cmake
>> index a3a6489..7484abd 100644
>> --- a/include/llvm/Support/DataTypes.h.cmake
>> +++ b/include/llvm/Support/DataTypes.h.cmake
>> @@ -79,18 +79,6 @@ typedef u_int64_t uint64_t;
>> #endif
>> #endif
>> 
>> -#ifdef _OpenBSD_
>> -#define INT8_MAX 127
>> -#define INT8_MIN -128
>> -#define UINT8_MAX 255
>> -#define INT16_MAX 32767
>> -#define INT16_MIN -32768
>> -#define UINT16_MAX 65535
>> -#define INT32_MAX 2147483647
>> -#define INT32_MIN -2147483648
>> -#define UINT32_MAX 4294967295U
>> -#endif
>> -
>> #else /* _MSC_VER */
>> /* Visual C++ doesn't provide standard integer headers, but it does provide
>>   built-in data types. */
>> diff --git a/include/llvm/Support/DataTypes.h.in b/include/llvm/Support/DataTypes.h.in
>> index b492bb1..b9fb48a 100644
>> --- a/include/llvm/Support/DataTypes.h.in
>> +++ b/include/llvm/Support/DataTypes.h.in
>> @@ -79,18 +79,6 @@ typedef u_int64_t uint64_t;
>> #endif
>> #endif
>> 
>> -#ifdef _OpenBSD_
>> -#define INT8_MAX 127
>> -#define INT8_MIN -128
>> -#define UINT8_MAX 255
>> -#define INT16_MAX 32767
>> -#define INT16_MIN -32768
>> -#define UINT16_MAX 65535
>> -#define INT32_MAX 2147483647
>> -#define INT32_MIN -2147483648
>> -#define UINT32_MAX 4294967295U
>> -#endif
>> -
>> #else /* _MSC_VER */
>> /* Visual C++ doesn't provide standard integer headers, but it does provide
>>   built-in data types. */
> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits