[llvm-commits] [PATCH] - Add region highlighting to LNT View2D.js.

[Daniel Dunbar]

Hey Michael,

Minor comments:

1. There is a bug in your first patch in the change in layoutGraph, it
no longer iterates over the plots.

2. I don't understand the point of the manipulation of fill_color you
do in a couple places. I think it could be cleaned up but I don't know
what it is trying to do and the comments are particularly clear. Why
does the opacity have anything to do with the line width?

Major comment:

1. It might make more sense to have the Graph2D provide an API
separate from plots for things like annotations, which don't
participate in layout. This is easy enough to change later though, so
I have no problem with the approach you took.

Otherwise, looks great, thanks!

 - Daniel

On Wed, Aug 1, 2012 at 6:48 PM, Michael Gottesman <mgottesman at apple.com> wrote:
> The following patches allow LNT to highlight the region in between two different revisions when it is
> displaying the time series results for a specific test/machine.
>
> The idea is that the graph shows you the entire graph (even outside of the revision
> range in question), so you can see if a regression recovered. This becomes an
> issue when one can not easily visually identify the section of the graph where the
> original regression occurred. The highlighting fixes this issue in a simple manner.
>
> Patch 1 contains the code for the changes to View2D.js and the second patch the changes to views.py
> necessary for this to work:
>
>
>
>
>
>
> Michael
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>