[llvm-commits] [PATCH] Fix shift immediate operand for ARM instruction ADR

[Renato Golin]

On 30 July 2012 12:29, Jiangning Liu <jiangning.liu at arm.com> wrote:
> This patch is to fix http://llvm.org/bugs/show_bug.cgi?id=13241.

Hi Jiangning,

In addAdrLabelOperands(), is it possible to not be an immediate, so
the dyn_cast will try to cast a NULL value? An "assert(isImm())" or
"if (!isImm()) return;" would be nice.

In getT2AdrLabelOpValue(), and "else if (Val < 0) {" would avoid the
extra unnecessary check when Val == INT32_MIN.

Rest looks ok.

-- 
cheers,
--renato

http://systemcall.org/