[llvm-commits] [llvm] r160796 - in /llvm/trunk: include/llvm/CodeGen/Passes.h include/llvm/InitializePasses.h lib/CodeGen/CMakeLists.txt lib/CodeGen/EarlyIfConversion.cpp lib/CodeGen/MachineTraceMetrics.cpp lib/CodeGen/MachineTraceMetrics.h

[Jakob Stoklund Olesen]

On Jul 26, 2012, at 11:57 AM, David Blaikie <dblaikie at gmail.com> wrote:

> On Thu, Jul 26, 2012 at 11:38 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
>> +  // Run a downwards post-order search for the trace end.
>> +  Bounds.Downward = true;
>> +  typedef po_ext_iterator<const MachineBasicBlock*, LoopBounds> DownwardPO;
>> +  for (DownwardPO I = po_ext_begin(MBB, Bounds), E = po_ext_end(MBB, Bounds);
>> +       I != E; ++I) {
>> +    DEBUG(dbgs() << "  succ for BB#" << I->getNumber() << ": ");
>> +    TraceBlockInfo &TBI = BlockInfo[I->getNumber()];
> 
> This variable is unused in release builds.
> 
>> +    // All the successors have been visited, pick the preferred one.
>> +    BlockInfo[I->getNumber()].Succ = pickTraceSucc(*I);
> 
> Did you intend to use it here? (TBI.Succ = ...)

Yes, thanks. r160798

/jakob