[llvm-commits] [llvm] r160602 - in /llvm/trunk: lib/Transforms/IPO/GlobalOpt.cpp test/Transforms/GlobalOpt/2009-11-16-BrokenPerformHeapAllocSRoA.ll test/Transforms/GlobalOpt/cleanup-pointer-root-users.ll

[Duncan Sands]

Hi Nick,

>> Because you get to eliminate lots of stores, i.e. all those that don't have
>> pointer type?
>
> I don't get it, isn't that what we do now? If the global has pointer type then
> all the stores have to be pointer typed or else the IR is invalid.

maybe I misread your patch, but it seemed to me that you disable the
optimization for an entire global of struct type if any field in it has
pointer type.  I'm in essence suggesting keeping the optimization for all
fields except those of pointer type.

Ciao, Duncan.