[llvm-commits] Patch to unify same code in multiple spots

[Villmow, Micah]

Ping, just want to confirm that this version of the patch is good before committing. 

Micah

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Villmow, Micah
> Sent: Monday, July 23, 2012 9:37 AM
> To: NAKAMURA Takumi
> Cc: llvm-commits at cs.uiuc.edu LLVM
> Subject: Re: [llvm-commits] Patch to unify same code in multiple spots
> 
> I've updated the patch to pass clang/llvm testing. It isn't as clean,
> but I don't see another way of doing it.
> 
> 
> mvillmow at caStarscream:/usr/src/llvm/llvm$ make check-all
> llvm[0]: Running test suite
> make[1]: Entering directory `/usr/src/llvm/llvm/test'
> Making LLVM 'lit.site.cfg' file...
> Making LLVM unittest 'lit.site.cfg' file...
> make -C /usr/src/llvm/llvm/test/../tools/clang/test lit.site.cfg
> Unit/lit.site.cfg
> make[2]: Entering directory `/usr/src/llvm/llvm/tools/clang/test'
> Making Clang 'lit.site.cfg' file...
> Making Clang 'Unit/lit.site.cfg' file...
> make[2]: Leaving directory `/usr/src/llvm/llvm/tools/clang/test'
> ( ulimit -t 600 ; ulimit -d 512000 ; ulimit -m 512000 ; ulimit -v
> 1024000 ; \
> 	  /usr/src/llvm/llvm/utils/lit/lit.py -s -v .
> /usr/src/llvm/llvm/test/../tools/clang/test )
> lit.py: lit.cfg:175: note: using clang:
> '/usr/src/llvm/llvm/Debug+Asserts/bin/clang'
> Testing Time: 131.68s
>   Expected Passes    : 11236
>   Expected Failures  : 81
>   Unsupported Tests  : 13
> make[1]: Leaving directory `/usr/src/llvm/llvm/test'
> 
> __________________
> From: NAKAMURA Takumi [geek4civic at gmail.com]
> Sent: Friday, July 20, 2012 7:20 PM
> To: Villmow, Micah
> Cc: llvm-commits at cs.uiuc.edu LLVM; Duncan Sands
> Subject: Re: [llvm-commits] Patch to unify same code in multiple spots
> 
> Micah, your patch breaks both llvm and clang tests.
> 
> Emitting separator should be suppressed if CC is default CallingConv::C.
> 
> ...Takumi
> 
> 2012/7/20 Villmow, Micah <Micah.Villmow at amd.com>:
> > In the AsmWriter.cpp, there are multiple spots where the same
> > information is printed out(except for a single space).
> >
> >
> >
> > This patch unifies these locations into a helper function making
> > adding new calling conventions less error prone as only a single
> > location needs to be modified.
> >
> >
> >
> > If this is good, please submit for me.
> >
> >
> >
> > Thanks,
> >
> > Micah
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >