[llvm-commits] Patch to unify same code in multiple spots

Duncan Sands baldrick at free.fr
Fri Jul 20 08:30:02 PDT 2012


Hi Micah,

>> 2012/7/20 Duncan Sands <baldrick at free.fr>:
>>> how about having the factorized function return the calling convention
>>> name as a const char *, since that's more general, and then do
>>>     Out << getCallingConvName(F->getCallingConv());
>>> etc.
>>
>> I thought it would be better idea, unless we had a form of "cc###".
> [Villmow, Micah] Yep, this would normally work except for the case of unknown calling convention, which is exactly how I found this code in multiple spots.

feel free to commit your patch.

Ciao, Duncan.




More information about the llvm-commits mailing list