[llvm-commits] [PATCH] ExecutionEngine/JIT: Run on host if target != host, as rework of PR11060.

[Sebastian Pop]

Hi,

I think that the patch makes sense.

There is one corner case that still could be addressed: when LLVM is
configured as a cross compiler, host != target, and LLVM cannot produce
code for the host, as it has been disabled with --enable-targets=target,
then I think that it makes sense to disable the execution engine.
What do other people think?

I'm not happy with the fact that most of the comments are missing a dot
at the end of the sentence. Thanks for addressing that issue in your patch.
Otherwise, your changes look good to me.

Thanks,
Sebastian

On Wed, Jul 18, 2012 at 4:52 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> autoconf: Re-introduce LLVM_HOSTTRIPLE since r143500.
>
> cmake: Add LLVM_HOSTTRIPLE. For now, it is same as TARGET_TRIPLE.
>
> ExecutionEngine/TargetSelect.cpp: Override default triple as LLVM_HOSTTRIPLE.
> ---
>  llvm/autoconf/configure.ac                   |    2 ++
>  llvm/cmake/config-ix.cmake                   |    1 +
>  llvm/configure                               |    5 +++++
>  llvm/include/llvm/Config/config.h.cmake      |    3 +++
>  llvm/include/llvm/Config/config.h.in         |    3 +++
>  llvm/include/llvm/Config/llvm-config.h.cmake |    3 +++
>  llvm/include/llvm/Config/llvm-config.h.in    |    3 +++
>  llvm/lib/ExecutionEngine/TargetSelect.cpp    |    2 +-
>  8 files changed, 21 insertions(+), 1 deletions(-)
>
> ---
> This patchset helps "configure --target=non-host".
> For example, http://lab.llvm.org:8011/builders/clang-x86_64-darwin11-cross-mingw32
> (--target=i686-pc-mingw32 --host=--build=x86_64-darwin)
>
> Confirmed with;
>   "--target=i686-pc-mingw32",
>   "--build=i686-redhat-linux CC='gcc -m32' CXX='g++ -m32' "
>   and cmake.
>
> ...Takumi
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum