[llvm-commits] Review Request: ARM ctpop

Jim Grosbach grosbach at apple.com
Tue Jul 17 15:44:16 PDT 2012


LGTM. Thanks!

-j
On Jul 17, 2012, at 3:36 PM, Joel Jones <joel_k_jones at apple.com> wrote:

> More replacing of  target-dependent intrinsics with target-indepdent 
> intrinsics.  The second instruction(s) to be handled are the vector versions 
> of count set bits (ctpop).
> 
> The changes here are to clang so that it generates a target independent 
> vector ctpop when it sees an ARM dependent vector bits set count.  The changes 
> in llvm are to match the target independent vector ctpop and in 
> VMCore/AutoUpgrade.cpp to update any existing bc files containing ARM 
> dependent vector pop counts with target-independent ctpops.  There are also 
> changes to an existing test case in llvm for ARM vector count instructions and 
> to a test for the bitcode upgrade.
> 
> <rdar://problem/11892519>
> 
> There is deliberately no test for the change to clang, as so far as I know, no
> consensus has been reached regarding how to test neon instructions in clang;
> q.v. <rdar://problem/8762292>
> 
> <clangDiff17Jul><llvmDiff17Jul>




More information about the llvm-commits mailing list