[llvm-commits] [llvm] r160254 - in /llvm/trunk: lib/Transforms/Instrumentation/AddressSanitizer.cpp test/Instrumentation/AddressSanitizer/basic.ll

[Kostya Serebryany]

On Tue, Jul 17, 2012 at 10:03 PM, Joerg Sonnenberger <
joerg at britannica.bec.de> wrote:

> On Tue, Jul 17, 2012 at 05:17:42PM +0400, Kostya Serebryany wrote:
> > > So in terms of lowering,
> > > LLVM could replace the "call __asan_report_read4" instruction with
> > > "pushq %0; jmp __asan_report_read4" or so. Alternatively, just change
> > > the ABI to not depend on __builtin_return_address sounds fine as well?
> > >
> >
> > How?
>
> I'm not sure how it can be abstracted in a general way. I'm not even
> sure it would help much either.
>

I am actually quite satisfied with the code that LLVM generates for asan
today.
I wouldn't change it at all, but there are those nasty compile-time
performance issues down stream.
We thought that reducing the number of BBs will help. Apparently it made
things worse due to increased number of PHIs.

 --kcc


> Joerg
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120717/cffc244f/attachment.html>