[llvm-commits] PATCH: Improve getSubprogramName in llvmDebugInfo lib

Benjamin Kramer benny.kra at gmail.com
Tue Jul 17 08:14:16 PDT 2012


On 17.07.2012, at 16:53, Alexey Samsonov <samsonov at google.com> wrote:

> Hi!
> 
> This patch improves the behavior of DebugInfoEntryMinimal::getSubprogramName() introduced in r159512.
> To fetch a subprogram name we should not only inspect the DIE for this subprogram, but optionally inspect
> its specification, or its abstract origin (even if there is no inlining), or even specification of an abstract origin.
> New test case checks that llvm-dwarfdump is able to correctly detect function name in the latter case.
> 
> Code review: http://codereview.appspot.com/6409051/

Posted some style nits in the code review tool, otherwise the patch looks good to me.

- Ben





More information about the llvm-commits mailing list