[llvm-commits] [llvm] r160273 - /llvm/trunk/test/CodeGen/R600/

Duncan Sands baldrick at free.fr
Mon Jul 16 07:39:37 PDT 2012


Hi Tom, adding a bunch of testcases that diff against binary blobs seems like a
really bad idea to me.  Suppose I make a change to codegen and one of these
tests breaks.  How am I to understand if the change I made just resulted in an
unimportant difference, such as slightly different register allocation, or if
I really broke something?

Ciao, Duncan.
> --- llvm/trunk/test/CodeGen/R600/fadd.ll (added)
> +++ llvm/trunk/test/CodeGen/R600/fadd.ll Mon Jul 16 09:17:19 2012
> @@ -0,0 +1,15 @@
> +;RUN: llc < %s -march=r600 -mcpu=redwood | diff %s.check -
> +
> +
> +define void @test() {
> +   %r0 = call float @llvm.R600.load.input(i32 0)
> +   %r1 = call float @llvm.R600.load.input(i32 1)
> +   %r2 = fadd float %r0, %r1
> +   call void @llvm.AMDGPU.store.output(float %r2, i32 0)
> +   ret void
> +}
> +
> +declare float @llvm.R600.load.input(i32) readnone
> +
> +declare void @llvm.AMDGPU.store.output(float, i32)
> +
>
> Added: llvm/trunk/test/CodeGen/R600/fadd.ll.check
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/R600/fadd.ll.check?rev=160273&view=auto
> ==============================================================================
> Binary files llvm/trunk/test/CodeGen/R600/fadd.ll.check (added) and llvm/trunk/test/CodeGen/R600/fadd.ll.check Mon Jul 16 09:17:19 2012 differ
...



More information about the llvm-commits mailing list