[llvm-commits] PATCH: Provide branch weight metadata for instrumentation branches in AddressSanitizer=

Kostya Serebryany kcc at google.com
Mon Jul 16 02:15:35 PDT 2012


Looks good!
I'll do the actual measurements to see if we missed something after the
commit

--kcc

On Mon, Jul 16, 2012 at 1:10 PM, Chandler Carruth <chandlerc at gmail.com>wrote:

> The patch helps....
>
>
> On Mon, Jul 16, 2012 at 2:10 AM, Chandler Carruth <chandlerc at gmail.com>wrote:
>
>> I have no idea if this heuristic is correct, but I suspect it's pretty
>> good...
>>
>> It doesn't really matter what heuristic is used if we insert
>> 'unreachable' -- that should trump all else, but it seemed simpler to just
>> always set a flat heavy bias toward the "nothing wrong" direction. Looking
>> at the asm output, the metadata has the desired effect.
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120716/16b2ad89/attachment.html>


More information about the llvm-commits mailing list