[llvm-commits] Review request: ARM vector ctlz should use target-independent intrinsic

Jim Grosbach grosbach at apple.com
Fri Jul 13 12:03:37 PDT 2012


Looks good.

Minor simplification for the test cases:

+;CHECK: {{vclz\.i8.*d[0-9]}}

No need to put the whole instruction in a regex like this. FileCheck is smart enough to handle whitespace and such, so you can just do, for example (also note the '+' on the register number so we can match things like "d15":
; CHECK: vclz.i8 {{d[0-9]+}}


On Jul 11, 2012, at 7:38 AM, Joel Jones <joel_k_jones at apple.com> wrote:

> This is one of the first steps at moving to replace target-dependent intrinsics with target-indepdent intrinsics.  The first instruction(s) to be handled are the vector versions of count leading zeros (ctlz).
> 
> The changes here are to clang so that it generates a target independent vector ctlz when it sees an ARM dependent vector ctlz.  The changes in llvm are to match the target independent vector ctlz and in VMCore/AutoUpgrade.cpp to update any existing bc files containing ARM dependent vector ctlzs with target-independent ctlzs.  There are also changes to an existing test case in llvm for ARM vector count instructions and a new test for the bitcode upgrade.
> 
> <rdar://problem/11831778>
> 
> Joel
> <clangDiff10JulFirst><llvmDiff10JulFirst>




More information about the llvm-commits mailing list