[llvm-commits] [llvm] r160127 - /llvm/trunk/autoconf/configure.ac

[Gabor Greif]

On 7/12/12, Eric Christopher <echristo at apple.com> wrote:
>
> On Jul 12, 2012, at 6:05 AM, Gabor Greif <ggreif at gmail.com> wrote:
>
>> Author: ggreif
>> Date: Thu Jul 12 08:05:12 2012
>> New Revision: 160127
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=160127&view=rev
>> Log:
>> fix typo in generated comment
>>
>
> If you aren't prepared to regenerate the files can you please just send me
> the patch and I'll apply it and regenerate in the future. It makes sure that
> the commits are reasonably atomic as far as configure goes.

I would have, but this was a 'drive-by' typo fix, lowest priority.
Sorry for not performing my duties.

>
> I've gone ahead and regenerated here:
>
> 	M	include/llvm/Config/config.h.in
> r160134 = 6d293cb7aa4930394b3a873889d83a0b9e1d9308
> (refs/remotes/origin/master)

Thank you. I am more interested in this:

<http://lists.cs.uiuc.edu/pipermail/llvmdev/2012-July/051716.html>

I wonder though, whether we can add some clever logic that
behaviour of PathUnix.inc does not change regardless
of the absence of the config #define. Then no cmake
change would be necessary. Or can we simply bake it into
some include/llvm/Config/config.h.in file?

Cheers,

    Gabor

>
> Thanks!
>
> -eric
>
>
>