[llvm-commits] [llvm] r156714 - in /llvm/trunk: lib/MC/MCParser/AsmParser.cpp test/MC/AsmParser/macro-rept-err1.s test/MC/A

[Rafael Espíndola]

On 10 July 2012 09:24, PaX Team <pageexec at freemail.hu> wrote:
> On 14 May 2012 at 19:12, Rafael Espíndola wrote:
>
> Hi Rafael,
>
> first of all, thank you for taking in most of the patches, i've just been very busy
> with other stuff and didn't have time to follow up so far. here i'd like to resubmit
> the missing and probably biggest part related to macro handling. it's a straightforward
> port from the previous submission, but with other pieces already in the tree, hopefully
> it's easier to digest ;).

Two quick first comments:

* Why you went back to passing SmallString<256>&?
* Can you put the typedefs and whitespaces in a first trivial patch?


Cheers,
Rafael