[llvm-commits] [PATCH] Proper treatment of unhandled CCValAssign cases in X86FastISel.cpp

[Kaylor, Andrew]

Hello all,

I came across a case today where the X86 fast instruction selector was throwing an llvm_unreachable error in response to a valid value for an argument location (CCValAssign::Indirect in the case I ran into).  I don't know if it would be reasonable to handle this case in the X86FastISel code, but in the meantime it seems the code should simply return 'false' when it encounters an unimplemented location type so that the SelectionDAG can handle it.

The attached patch does that.

-Andy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120711/5cd7e071/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: X86FastISel.patch
Type: application/octet-stream
Size: 482 bytes
Desc: X86FastISel.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120711/5cd7e071/attachment.obj>