[llvm-commits] PATCH: Fix DebugInfo codegen so that it doesn't duplicate debug info entries for variables in inlined functions (PR13202)

[Eric Christopher]

On Jun 29, 2012, at 10:24 AM, Alexey Samsonov <samsonov at google.com> wrote:

> Hi!
> 
> DwarfDebug class can generate the same (inlined) DIVariable twice:
> 1) when trying to find abstract debug variable for a concrete inlined instance
> 2) when explicitly collecting info for variables that were optimized out. 
> 
> Duplicated DIEs for variables confuses e.g. gdb (it shows two identical function arguments).
> I've attached the proposed little patch and a testcase. Please take a look.
> 
> (more context - http://llvm.org/bugs/show_bug.cgi?id=13202)

Looks ok, but please:

a) Add a comment as to what's going on and point to the other use of cleanseInlinedVariable,
b) Run it on a testsuite like gdb or lldb as well (or if you have let me know how it went).

Thanks!

-eric