[llvm-commits] [PATCH] Target specific max stack alignment

Chad Rosier mcrosier at apple.com
Tue Jul 3 12:22:08 PDT 2012


After discussing this with Bob, I've decided to retract this patch.  This isn't quite what we wanted and Joerg makes a good point.

 Chad

On Jul 3, 2012, at 11:25 AM, Eric Christopher wrote:

> 
> On Jul 3, 2012, at 12:58 AM, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:
> 
>> On Mon, Jul 02, 2012 at 01:19:14PM -0700, Chad Rosier wrote:
>>> All,
>>> The attached patch allows targets to specify a max stack alignment.
>>> The goal is to prevent wasted stack space when locals are over aligned.
>> 
>> I can think of valid reasons for forcing stack alignment of variables
>> larger than what the CPU requires. As such, I don't really like this.
> 
> Sure, but in the case where the backend for some reason can't support
> doing that setting it up so that the frontend can warn is preferable to
> dropping it on the floor.
> 
> -eric
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list