[llvm-commits] PATCH: [lld] Trivial update to ReaderCOFF.cpp

Sid Manning sidneym at codeaurora.org
Thu Jun 28 09:28:53 PDT 2012


On 06/28/12 10:42, Clow, Marshall wrote:
> On Jun 27, 2012, at 2:21 PM, Sid Manning wrote:
>
>> This change fixes the following link errors.
>>
>> undefined reference to `lld::ReaderOptionsPECOFF::ReaderOptionsPECOFF()'
>> undefined reference to `lld::ReaderOptionsPECOFF::~ReaderOptionsPECOFF()'
>>
>> By adding empty versions of ReaderOptionsPECOFF and ~ReaderOptionsPECOFF.
>
> If the constructor and destructor are empty, then why not remove the declarations, and let the compiler generate them?
>
> -- Marshall
>
>
I followed the pattern in YAML. It looks like the options are present to 
control the operation of the reader, they are just not used for COFF or 
ELF yet.  What would need to happen to get the compiler to automatically 
generate them?



More information about the llvm-commits mailing list