[llvm-commits] [RFC] Patch 1/3 for the native code compiler of Erlang

[Yiannis Tsiouris]

On 06/24/2012 04:34 PM, Anton Korobeynikov wrote:
> Hello Yannis,
Hi Anton,

Thanks for finding some time to look at this! :-)

>> Can someone please review the attatched?
> Generally looks good to me. Few things to fix though:
> 1. Make sure you're not using tabs and the code style is same compared
> to encosing file
I 've fixed some whitespace errors and slightly refactored the patch to
match the coding standards of the modified files. Feel free to point me
to some more modification if you want!

> 2. I'm bit concerned about code like "+  bool isHipeCall = (F ?
> F->getCallingConv() == CallingConv::HiPE : false);"
What are exactly your concerns about it?

>
> It seems you require tail call optimizations on every call, right?
> What will be if the call will be via function pointer?
Yes, HiPE CC should support tailcall optimization for every call. I
don't quite understand what's the potential problem here... What do you
mean a "call via function pointer"?


Best regards,
Yiannis

-- 
Yiannis Tsiouris
Ph.D. student,
Software Engineering Laboratory,
National Technical University of Athens
WWW: http://www.softlab.ntua.gr/~gtsiour

-------------- next part --------------
A non-text attachment was scrubbed...
Name: hipe-calling-conv-v2.patch
Type: text/x-diff
Size: 11951 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120625/d1eadfb3/attachment.patch>