[llvm-commits] [dragonegg, patch] Pass TLS model through to LLVM

Hans Wennborg hans at chromium.org
Mon Jun 25 10:03:40 PDT 2012


On Fri, Jun 8, 2012 at 3:55 PM, Hans Wennborg <hans at chromium.org> wrote:
> While waiting for the main tls_model patch [1] to be reviewed, here is
> a patch that makes dragonegg pass the TLS model through to LLVM's
> GlobalVariable.
>
> Thanks,
> Hans
>
> [1]. http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120604/143997.html

Now that the main tls_model patch landed in LLVM, this is ready to land.

When this was reviewed on IRC, Duncan asked for

1) Remove the "svn:eol-style   + LF" thing
2) Make the switch cover TLS_MODEL_REAL, and test for it.

I've fixed 1), but I discovered that the enumerators TLS_MODEL_REAL
and TLS_MODEL_GLOBAL_DYNAMIC are actually the same. I added a variable
without explicit tls model to the test, though.

Let me know if this is OK to commit.

Thanks,
Hans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tls_models_dragonegg2.diff
Type: application/octet-stream
Size: 1946 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120625/c43907ea/attachment.obj>


More information about the llvm-commits mailing list