[llvm-commits] [RFC] Patch 1/3 for the native code compiler of Erlang

Anton Korobeynikov anton at korobeynikov.info
Sun Jun 24 06:34:15 PDT 2012


Hello Yannis,

> Can someone please review the attatched?
Generally looks good to me. Few things to fix though:
1. Make sure you're not using tabs and the code style is same compared
to encosing file
2. I'm bit concerned about code like "+  bool isHipeCall = (F ?
F->getCallingConv() == CallingConv::HiPE : false);"

It seems you require tail call optimizations on every call, right?
What will be if the call will be via function pointer?

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University



More information about the llvm-commits mailing list