[llvm-commits] [PATCH] Add relocation types for Hexagon processor

Michael Spencer bigcheesegs at gmail.com
Fri Jun 22 16:46:38 PDT 2012


On Fri, Jun 22, 2012 at 10:03 AM, Sidney Manning <sidneym at codeaurora.org> wrote:
>
>
>
> > -----Original Message-----
> > From: Evandro Menezes [mailto:emenezes at codeaurora.org]
> > Sent: Thursday, June 21, 2012 4:13 PM
> > To: Sidney Manning
> > Cc: llvm-commits at cs.uiuc.edu
> > Subject: Re: [llvm-commits] [PATCH] Add relocation types for Hexagon
> > processor
> >
> > Sid,
> >
> > I'm not sure either about how to handle the binary file, but your
> > description makes sense.
> >
> > You referred to an internal document that, since it's not available
> > publicly yet, probably doesn't make sense to figure in the code-base.
> >
> Ok, I removed the document reference and reattached the patch.
>
> Thanks,
>
>
> > Other than that, it looks good to me.
> >
> > --
> > Evandro Menezes          Austin, TX          emenezes at codeaurora.org
> > Qualcomm Innovation Center, Inc is a member of the Code Aurora Forum
> >
> >
> > On 06/19/12 16:04, Sidney Manning wrote:
> > > I would like to submit the following patch for review. This is my
> > > first patch to llvm and it adds relocation types used by Qualcomm’s
> > > Hexagon processor. I extended the objdump-relocations.test to verify
> > a
> > > few of the newly added relocs, similar to what I saw x86 doing.
> > >
> > > There are two attachments to this email, the normal diff and a binary
> > > file. The binary is a hexagon object file used by
> > > objdump-relocations.test to check a few of the newly added relocs. It
> > > should be uncompressed and placed into the ~test/Object/Inputs
> > directory.
> > >
> > > Thanks,
> > >
> > >
> > >
> > > _______________________________________________
> > > llvm-commits mailing list
> > > llvm-commits at cs.uiuc.edu
> > > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>

LGTM.

- Michael Spencer




More information about the llvm-commits mailing list