[llvm-commits] Patch: compiler-rt/lib/divsi3.c: do not call udivsi3 directly

Stephen Canon scanon at apple.com
Fri Jun 22 07:35:35 PDT 2012


On Jun 22, 2012, at 5:35 AM, Sébastien Bourdeauducq <sebastien.bourdeauducq at lekernel.net> wrote:

> On 06/22/2012 10:10 AM, Anton Korobeynikov wrote:
>>> The patch doesn't seem that obvious at first glance -
>>> does your assumption about the compiler behavior always hold? (if yes,
>>> please add
>>> an explicit comment about it) Also, I'm not the author of the core
>>> compiler-rt lib and don't know if optional hardware support is desirable here.
>> +1 We should be careful here and not to introduce the cycle (divsi
>> calls udivs which will end calling divsi again :) )
> 
> This problem is already present in the current code. How about this updated patch with a few comments?

LGTM.  Do you have commit access?

- Steve



More information about the llvm-commits mailing list