[llvm-commits] [PATCH] Fix bug in SExt optimsations

James Benton jbenton at vmware.com
Thu Jun 21 08:55:05 PDT 2012


On 21/06/12 16:48, Anton Korobeynikov wrote:
> Hi James,
>
>> Two diffs, one for llvm which fixes the bug and one for nightly test-suite
>> which tests the bug.
> The tests for such sort of thing should be a part of standard
> regression testsuite.
>
On 21/06/12 16:30, Rafael EspĂ­ndola wrote:
> On 21 June 2012 08:13, James Benton<jbenton at vmware.com>  wrote:
>> Two diffs, one for llvm which fixes the bug and one for nightly test-suite
>> which tests the bug.
> Can't it be tested with llvm's own "make check"?
>
> Cheers,
> Rafael

I was told by Duncan Sands to move the test from the regression suite to 
the nightly tests as it relies upon execution of code rather than just 
compiling it.

But no one ever committed it after the change was made.

Quote from his email below.

Thanks,
James

----- Original Message -----

> Hi James,
>
>> We were emitting 0/1 booleans, instead of 0/-1 booleans.
>>
>> Ran full test suite to ensure no regressions.
> +++ b/test/CodeGen/Generic/sext-setcc-self.ll
> @@ -0,0 +1,76 @@
> +; RUN: %lli %s | grep {^0xFFFFFFFF 0xFFFFFFFF 0xFFFFFFFF
> 0xFFFFFFFF$}
>
> I'm pretty sure you aren't supposed to be executing code like this in
> the
> regression testsuite, instead you should do pattern matching.  Code
> to be
> executed belongs in the nightly testsuite.  I could be wrong about
> this,
> but I think it's the policy.
>
> Ciao, Duncan.
>
> PS: Otherwise it looks OK.



More information about the llvm-commits mailing list