[llvm-commits] [llvm] r158893 - /llvm/trunk/unittests/CMakeLists.txt

[Chandler Carruth]

On Wed, Jun 20, 2012 at 10:45 PM, Chandler Carruth <chandlerc at gmail.com>wrote:

> On Wed, Jun 20, 2012 at 9:59 PM, NAKAMURA Takumi <geek4civic at gmail.com>wrote:
>
>> It seems you have changed structure of output directory.
>> You can see duplicated unittests on incremental builds.
>>
> Can you explain the change? I didn't see any?
>

Sorry, I see now. My bad.

I think I have fixed this in r158909 and r158910, everything should be back
to its old location. Sorry for the churn to incremental builders.


> I am working to restructure unittests, too, but under checking yet...
>>
> Hope I didn't clobber your work any, I just had a reason to dig in and
make this stuff a bit cleaner so I could reuse these pieces elsewhere.


> 2012/06/21 11:06 "Chandler Carruth" <chandlerc at gmail.com>:
>>
>> Author: chandlerc
>>> Date: Wed Jun 20 21:02:48 2012
>>> New Revision: 158893
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=158893&view=rev
>>> Log:
>>> Simplify the naming pattern in the unittests' CMake file
>>>
>>> Modified:
>>>    llvm/trunk/unittests/CMakeLists.txt
>>>
>>> Modified: llvm/trunk/unittests/CMakeLists.txt
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/CMakeLists.txt?rev=158893&r1=158892&r2=158893&view=diff
>>>
>>> ==============================================================================
>>> --- llvm/trunk/unittests/CMakeLists.txt (original)
>>> +++ llvm/trunk/unittests/CMakeLists.txt Wed Jun 20 21:02:48 2012
>>> @@ -11,15 +11,15 @@
>>>     set(EXCLUDE_FROM_ALL ON)
>>>   endif()
>>>
>>> -  add_llvm_executable(${test_name}Tests ${ARGN})
>>> -  target_link_libraries(${test_name}Tests
>>> +  add_llvm_executable(${test_name} ${ARGN})
>>> +  target_link_libraries(${test_name}
>>>     gtest
>>>     gtest_main
>>>     LLVMSupport # gtest needs it for raw_ostream.
>>>     )
>>>
>>> -  add_dependencies(UnitTests ${test_name}Tests)
>>> -  set_target_properties(${test_name}Tests PROPERTIES FOLDER "Tests")
>>> +  add_dependencies(UnitTests ${test_name})
>>> +  set_target_properties(${test_name} PROPERTIES FOLDER "Tests")
>>>  endfunction()
>>>
>>>  # Visual Studio 2012 only supports up to 8 template parameters in
>>> @@ -58,7 +58,7 @@
>>>   Support
>>>   )
>>>
>>> -add_llvm_unittest(ADT
>>> +add_llvm_unittest(ADTTests
>>>   ADT/APFloatTest.cpp
>>>   ADT/APIntTest.cpp
>>>   ADT/BitVectorTest.cpp
>>> @@ -87,11 +87,11 @@
>>>   ADT/VariadicFunctionTest.cpp
>>>  )
>>>
>>> -add_llvm_unittest(Analysis
>>> +add_llvm_unittest(AnalysisTests
>>>   Analysis/ScalarEvolutionTest.cpp
>>>   )
>>>
>>> -add_llvm_unittest(ExecutionEngine
>>> +add_llvm_unittest(ExecutionEngineTests
>>>   ExecutionEngine/ExecutionEngineTest.cpp
>>>   )
>>>
>>> @@ -130,13 +130,15 @@
>>>   list(APPEND JITTestsSources ExecutionEngine/JIT/JITTests.def)
>>>  endif()
>>>
>>> -add_llvm_unittest(ExecutionEngine/JIT ${JITTestsSources})
>>> +add_llvm_unittest(ExecutionEngine/JITTests
>>> +  ${JITTestsSources}
>>> +  )
>>>
>>>  if(MINGW OR CYGWIN)
>>>   set_property(TARGET JITTests PROPERTY LINK_FLAGS
>>> -Wl,--export-all-symbols)
>>>  endif()
>>>
>>> -add_llvm_unittest(Transforms/Utils
>>> +add_llvm_unittest(Transforms/UtilsTests
>>>   Transforms/Utils/Cloning.cpp
>>>   )
>>>
>>> @@ -156,9 +158,11 @@
>>>   list(REMOVE_ITEM VMCoreSources VMCore/ValueMapTest.cpp)
>>>  endif()
>>>
>>> -add_llvm_unittest(VMCore ${VMCoreSources})
>>> +add_llvm_unittest(VMCoreTests
>>> +  ${VMCoreSources}
>>> +  )
>>>
>>> -add_llvm_unittest(Bitcode
>>> +add_llvm_unittest(BitcodeTests
>>>   Bitcode/BitReaderTest.cpp
>>>   )
>>>
>>> @@ -167,7 +171,7 @@
>>>   Core
>>>   )
>>>
>>> -add_llvm_unittest(Support
>>> +add_llvm_unittest(SupportTests
>>>   Support/AlignOfTest.cpp
>>>   Support/AllocatorTest.cpp
>>>   Support/BlockFrequencyTest.cpp
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120621/d643329e/attachment.html>