[llvm-commits] [LLVMdev] How to define macros in a tablegen file?

Villmow, Micah Micah.Villmow at amd.com
Wed Jun 20 14:43:01 PDT 2012


Ok, I was thinking there might be a test similar to PatFrag that could be created, but I noticed there are no tests for PatFrag either.

So that patch looks fine to me.

Micah

> -----Original Message-----
> From: Sebastian Pop [mailto:spop at codeaurora.org]
> Sent: Wednesday, June 20, 2012 2:02 PM
> To: Villmow, Micah
> Cc: llvm-commits at cs.uiuc.edu; llvmdev at cs.uiuc.edu
> Subject: Re: [llvm-commits] [LLVMdev] How to define macros in a
> tablegen file?
> 
> On Wed, Jun 20, 2012 at 3:40 PM, Villmow, Micah <Micah.Villmow at amd.com>
> wrote:
> > Possible to add a test case?
> 
> I am not really sure what I would check.
> 
> At first, I thought to add a testcase to test/TableGen; as this patch
> does not modify tablegen, it doesn't make sense.
> 
> What kind of test should I write for this?  The test should be a
> tablegen file that includes "llvm/Target/TargetSelectionDAG.td" or
> "llvm/Target/Target.td", and I haven't seen any of these in the
> testsuite.
> 
> Sebastian
> --
> Qualcomm Innovation Center, Inc is a member of Code Aurora Forum






More information about the llvm-commits mailing list