[llvm-commits] [compiler-rt] r158811 - in /compiler-rt/trunk/lib: CMakeLists.txt asan/CMakeLists.txt sanitizer_common/CMakeLists.txt

Kostya Serebryany kcc at google.com
Wed Jun 20 04:01:44 PDT 2012


On Wed, Jun 20, 2012 at 2:56 PM, Chandler Carruth <chandlerc at gmail.com>wrote:

> On Wed, Jun 20, 2012 at 3:39 AM, Kostya Serebryany <kcc at google.com> wrote:
>
>>
>>
>> On Wed, Jun 20, 2012 at 2:18 PM, Chandler Carruth <chandlerc at gmail.com>wrote:
>>
>>> Author: chandlerc
>>> Date: Wed Jun 20 05:18:43 2012
>>> New Revision: 158811
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=158811&view=rev
>>> Log:
>>> Resuming work on the compiler-rt CMake build at long long last. In order
>>> to get it working again, two changes were needed:
>>>
>>> - I had to give up on glob-based file expansion.
>>
>>
>> I never used cmake, but this sounds strange.
>> At least this is a regression compared to the old makefiles, which use
>> glob expansion.
>> Not a big deal, but until we switch to cmake completely, it'll be hard to
>> maintain it in working state.
>>
>
> Yea, it's annoying as hell IMO. the CMake devs won't prioritize a fast
> system for discovering new files or deleted files and propagating deps. I
> don't know why. It's really not that hard...
>
> Anyways, maintaining the list of files is super easy, so it's not a big
> deal from my perspective. We regularly have to go in and update the cmake
> build when new files come in outside of compiler-rt. ;]
>
> I don't expect anyone but me to really maintain this until I get it
> actually functional. It's actually not far from that for ASan, and in
> particular should soon have better support than the makefiles for running
> tests...
>

Lovely!



> But not quite yet....
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120620/6e2d3704/attachment.html>


More information about the llvm-commits mailing list