[llvm-commits] [PATCH] [pr12913] Have ARM ELF use correct reloc for "b" instr

Jan Voung jvoung at google.com
Tue Jun 19 09:05:52 PDT 2012


Thanks for the thorough review Tim! Committed r158722.

On Tue, Jun 19, 2012 at 1:40 AM, Tim Northover <t.p.northover at gmail.com>wrote:

> Hi Jan,
>
> >> The condition code didn't actually matter for arm "b" instructions,
> >> unlike "bl".  It should just use the R_ARM_JUMP24 reloc.
> >
> > Ok to commit?  Patch reattached, based on r158659
>
> It looks correct to me. The ARM ELF ABI says that a linker is
> permitted to convert anything relocated with R_ARM_CALL to a "BLX"
> which would be flat-out wrong for a "B". It also says that R_ARM_PLT32
> is deprecated in favour of R_ARM_JUMP24 (etc) so the PCRel changes
> should be correct. Tested too.
>
> You can commit as far as I'm concerned (whatever that counts for).
>
> Tim.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120619/9202e9c0/attachment.html>


More information about the llvm-commits mailing list