[llvm-commits] [llvm] r158087 - in /llvm/trunk: lib/Target/X86/X86FrameLowering.cpp lib/Target/X86/X86RegisterInfo.cpp lib/Target/X86/X86RegisterInfo.h test/CodeGen/X86/alloca-align-rounding-32.ll test/CodeGen/X86/alloca-align-rounding.ll test/Co

[Anton Korobeynikov]

> I understand the underlying issue, but I'm not familiar enough with the
> frame handling code to point you in the right direction this very moment.
>  Essentially, the pops should be relative to the BP (RBX I believe), not the
> SP.
> Matt and I stared at it a bit, and it seems like there may be completely
> missing handling of the particular combination of features that this patch
> enables in a few places. If there is somewhere we can contribute patches to,
> let us know?
It seems that frame lowering code needs to be audited as a whole and
probably even refactored....
We can surely may not use pops when restoring stuff with realigned
stack, instead ordinary loads from stack can be issues (see e.g. case
for high xmm registers for win64 ABI).

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University