[llvm-commits] [llvm] r158586 - /llvm/trunk/include/llvm/ADT/DenseMap.h

Jakob Stoklund Olesen stoklund at 2pi.dk
Fri Jun 15 19:04:18 PDT 2012


On Jun 15, 2012, at 6:18 PM, Chandler Carruth wrote:

> This is pretty ugly, but it allows the super class to change the
> representation of these values, which will be key for doing
> a SmallDenseMap.
> 
> Suggestions on better method structuring / naming are welcome, but keep
> in mind that SmallDenseMap won't have an 'unsigned' member to expose
> a reference to... =/

Do we have any use cases where a DenseMap would be better than a SmallDenseMap? It's hard to think of cases where std::vector is better than SmallVector.

It seems this could be a lot simpler if you didn't have to preserve the original DenseMap exactly.

/jakob

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120615/8608aa21/attachment.html>


More information about the llvm-commits mailing list