[llvm-commits] [lld] r158375 - in /lld/trunk/lib/ReaderWriter/MachO: ReferenceKinds.cpp ReferenceKinds.h StubAtoms_x86.hpp StubAtoms_x86_64.hpp

[Chris Lattner]

On Jun 12, 2012, at 4:01 PM, Nick Kledzik wrote:

> Author: kledzik
> Date: Tue Jun 12 18:01:30 2012
> New Revision: 158375
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=158375&view=rev
> Log:
> flesh out mach-o Reference Kinds

Nice!

> Modified: lld/trunk/lib/ReaderWriter/MachO/ReferenceKinds.cpp
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/ReferenceKinds.cpp?rev=158375&r1=158374&r2=158375&view=diff
> ==============================================================================
> --- lld/trunk/lib/ReaderWriter/MachO/ReferenceKinds.cpp (original)
> +++ lld/trunk/lib/ReaderWriter/MachO/ReferenceKinds.cpp Tue Jun 12 18:01:30 2012
> @@ -53,25 +53,39 @@
> 
> Reference::Kind KindHandler_x86_64::stringToKind(StringRef str) {
>   if ( str.equals("none") )
> +    return none;
> +  else if ( str.equals("branch32") )
> +    return branch32;
>   else if ( str.equals("ripRel32") )
> +    return ripRel
...

Just a random pointer, the llvm/ADT/StringSwitch.h API can simplify this sort of code quite a bit, giving you something like:

  Reference::Kind KindHandler_x86_64::stringToKind(StringRef str) {
    return StringSwitch<Reference::Kind>(str)
      .Case("none", none)
      .Case("branch32", branch32)
    ...

-Chris