[llvm-commits] [llvm] r158226 - /llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp

[Charles Davis]

On Jun 8, 2012, at 2:15 PM, Duncan Sands wrote:

> Author: baldrick
> Date: Fri Jun  8 15:15:33 2012
> New Revision: 158226
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=158226&view=rev
> Log:
> Reapply commit 158073 with a fix (the testcase was already committed).  The
> problem was that by moving instructions around inside the function, the pass
> could accidentally move the iterator being used to advance over the function
> too.  Fix this by only processing the instruction equal to the iterator, and
> leaving processing of instructions that might not be equal to the iterator
> to later (later = after traversing the basic block; it could also wait until
> after traversing the entire function, but this might make the sets quite big).
I don't know about you, but I'm still seeing this problem even with this fix (i.e. Clang hangs in Reassociate while compiling ClangAttrEmitter.cpp).

Do you want me to revert (again) and file a bug?

Chip