[llvm-commits] [llvm] r158021 - in /llvm/trunk: include/llvm/CodeGen/ScheduleDAG.h include/llvm/CodeGen/ScheduleDAGInstrs.h include/llvm/MC/MCInstrItineraries.h include/llvm/Target/TargetInstrInfo.h lib/CodeGen/MachineScheduler.cpp lib/CodeGen/ScheduleDAGInstrs.cpp lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.h lib/CodeGen/TwoAddressInstructionPass.cpp lib/Target/ARM/ARMBaseInstrInfo.cpp lib/Target/ARM/ARMBaseInstrInfo.h lib/Target/TargetInstrInfo.cpp

[Tobias Grosser]

On 06/05/2012 11:11 PM, Andrew Trick wrote:
> Author: atrick
> Date: Tue Jun  5 16:11:27 2012
> New Revision: 158021
>
> URL: http://llvm.org/viewvc/llvm-project?rev=158021&view=rev
> Log:
> misched: API for minimum vs. expected latency.
>
> Minimum latency determines per-cycle scheduling groups.
> Expected latency determines critical path and cost.

This commit broke a cmake BUILD_SHARED_LIBS=ON build:

Linking CXX executable ../../bin/opt
../../lib/libLLVMTarget.so: error: undefined reference to 
'llvm::MachineInstr::hasPropertyInBundle(unsigned int, 
llvm::MachineInstr::QueryType) const'
../../lib/libLLVMTarget.so: error: undefined reference to 
'llvm::MachineInstr::findRegisterDefOperandIdx(unsigned int, bool, bool, 
llvm::TargetRegisterInfo const*) const'

The normal static linking hides this, but this commit introduces a 
dependency from Target to Codegen. Such a dependency cannot be added to 
the LLVMBuild.txt files as it introduces a dependency cycle.

Would you mind having a look.

Tobias