[llvm-commits] [lld] r158134 - in /lld/trunk: include/lld/Core/File.h include/lld/Core/Pass.h lib/ReaderWriter/PECOFF/ReaderCOFF.cpp lib/ReaderWriter/YAML/ReaderYAML.cpp

[Nick Kledzik]

Author: kledzik
Date: Wed Jun  6 20:53:39 2012
New Revision: 158134

URL: http://llvm.org/viewvc/llvm-project?rev=158134&view=rev
Log:
fix warnings found after cranking up warnings

Modified:
    lld/trunk/include/lld/Core/File.h
    lld/trunk/include/lld/Core/Pass.h
    lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp
    lld/trunk/lib/ReaderWriter/YAML/ReaderYAML.cpp

Modified: lld/trunk/include/lld/Core/File.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/File.h?rev=158134&r1=158133&r2=158134&view=diff
==============================================================================
--- lld/trunk/include/lld/Core/File.h (original)
+++ lld/trunk/include/lld/Core/File.h Wed Jun  6 20:53:39 2012
@@ -110,6 +110,7 @@
   template <typename T>
   class atom_collection {
   public:
+    virtual ~atom_collection() { }
     virtual atom_iterator<T> begin() const = 0;
     virtual atom_iterator<T> end() const = 0;
     virtual const T* deref(const void* it) const = 0;

Modified: lld/trunk/include/lld/Core/Pass.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/Pass.h?rev=158134&r1=158133&r2=158134&view=diff
==============================================================================
--- lld/trunk/include/lld/Core/Pass.h (original)
+++ lld/trunk/include/lld/Core/Pass.h Wed Jun  6 20:53:39 2012
@@ -34,6 +34,8 @@
 ///
 class Pass {
 public:
+  virtual ~Pass() { }
+
     /// Do the actual work of the Pass.
     virtual void perform(File& mergedFile) = 0;
 

Modified: lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp?rev=158134&r1=158133&r2=158134&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp (original)
+++ lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp Wed Jun  6 20:53:39 2012
@@ -22,9 +22,10 @@
 #include <map>
 #include <vector>
 
-using namespace lld;
 using llvm::object::coff_symbol;
 
+namespace lld {
+
 class COFFAbsoluteAtom : public AbsoluteAtom {
 public:
   COFFAbsoluteAtom(const File &F, llvm::StringRef N, uint64_t V)
@@ -376,9 +377,10 @@
 };
 
 
-
 Reader* createReaderPECOFF(const ReaderOptionsPECOFF &options) {
   return new ReaderCOFF(options);
 }
 
+} // namespace lld
+
 

Modified: lld/trunk/lib/ReaderWriter/YAML/ReaderYAML.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/YAML/ReaderYAML.cpp?rev=158134&r1=158133&r2=158134&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/YAML/ReaderYAML.cpp (original)
+++ lld/trunk/lib/ReaderWriter/YAML/ReaderYAML.cpp Wed Jun  6 20:53:39 2012
@@ -1197,9 +1197,9 @@
 }
 
 
-/// parseObjectText - Parse the specified YAML formatted MemoryBuffer
+/// parseFile - Parse the specified YAML formatted MemoryBuffer
 /// into lld::File object(s) and append each to the specified vector<File*>.
-error_code parseFile(std::unique_ptr<MemoryBuffer> &mb,
+static error_code parseFile(std::unique_ptr<MemoryBuffer> &mb,
                       const ReaderOptionsYAML &options,
                       std::vector<std::unique_ptr<File>> &result) {
   llvm::SourceMgr       srcMgr;