[llvm-commits] PATCH: Scalar Replacement of Aggregates Pass - Add more threshold parameters

Rotem, Nadav nadav.rotem at intel.com
Wed Jun 6 11:47:11 PDT 2012


LGTM. 

I remember seeing another parameter which controls the size of structs which can be converted into a single wide load instruction. It's also worth adding a parameter for that one.

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Tom Stellard
Sent: Wednesday, June 06, 2012 18:26
To: llvm-commits at cs.uiuc.edu
Subject: [llvm-commits] PATCH: Scalar Replacement of Aggregates Pass - Add more threshold parameters

Hi,

The attached pass allows users of the SROA pass to specify threshold values for the maximum number of struct members and number of array elements that can be considered for SROA.

The current hard-coded threshold value for maximum number of array elements is 8.  This is too small for GPUs targeted by the R600 backend which have 512 general purpose registers, so it would be very useful for these targets to be able to manually specify these threshold values.

Please Review.

Thanks,
Tom
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.





More information about the llvm-commits mailing list