[llvm-commits] [PATCH] Add support for functions with VLAs and dynamic stack realignment on x86

Chad Rosier mcrosier at apple.com
Wed Jun 6 10:47:38 PDT 2012


Committed revision 158087.  Thanks for the reviews, Jakob and Anton.

Anton,
After discussing things over with Jakob a bit I believe we've come to the conclusion that this should "just work", but then again I may be missing something.  Is there a specific case that is causing you concern?

 Chad

On Jun 5, 2012, at 3:52 PM, Anton Korobeynikov wrote:

> Hi Chad,
> 
>> No, I did not.  Note: -x86-use-base-pointer is true by default.  Thanks, Jakob.
> LGTM as well. But please make sure dwarf emission is correct /
> implement missing bits. Otherwise we'll end with really subtle
> problems when stack will be unwound through the base-reserving
> functions...
> 
> -- 
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State University




More information about the llvm-commits mailing list