[llvm-commits] [PATCH] Fix gtest build on Visual Studio 2012 RC

Chandler Carruth chandlerc at google.com
Tue Jun 5 18:23:50 PDT 2012


Sorry, missed the patch.

LGTM, please commit.

On Tue, Jun 5, 2012 at 6:15 PM, Justin Holewinski <
justin.holewinski at gmail.com> wrote:

> Anyone against committing this?
>
>
> On Mon, Jun 4, 2012 at 11:02 PM, Justin Holewinski <
> justin.holewinski at gmail.com> wrote:
>
>> An apparent change to the Visual C++ STL for Visual Studio 2012 is
>> causing gtest to no longer build.  gtest requires std::tr1::tuple to
>> support up to 10 template parameters, but the implementation in Visual
>> Studio 2012 RC only supports up to 8 by default.  This patch adds a
>> compiler definition (-D_VARIADIC_MAX=10) to the gtest libs and unit tests
>> when MSVC_VERSION == 1700.
>>
>> Upstream issue:
>> http://code.google.com/p/googletest/issues/detail?id=408
>>
>> --
>>
>> Thanks,
>>
>> Justin Holewinski
>>
>>
>
>
> --
>
> Thanks,
>
> Justin Holewinski
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120605/2161819a/attachment.html>


More information about the llvm-commits mailing list