[llvm-commits] [llvm] r157884 - in /llvm/trunk: include/llvm/Instructions.h include/llvm/Support/IntegersSubset.h include/llvm/Support/IntegersSubsetMapping.h lib/Bitcode/Writer/BitcodeWriter.cpp lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp l

Stepan Dyatkovskiy stpworld at narod.ru
Sun Jun 3 10:03:44 PDT 2012


Hi Takumi,
According to CPP standard (Special member functions, Copying class 
objects, point 8), the default copy constructor should perform 
memberwise copy of its subobjects. So I removed these strings since it 
is exactly what the default copy ctor does.

Did you got any failures or warnings after I removed it?

-Stepan.

NAKAMURA Takumi wrote:
> Stepan,
>
>> -    IntRange(const self&RHS) :
>> -      Low(RHS.Low), High(RHS.High), IsEmpty(false), IsSingleNumber(false) {}
>
> I have restored it as explicit copy constructor in r157901.
> I don't think my fix would be reasonable. Please reconfirm.
>
> FYI, one of my builders, x86_64-linux, uses g++-4.4.6.
>
> ...Takumi




More information about the llvm-commits mailing list