[llvm-commits] [llvm] r157777 - in /llvm/trunk: lib/Transforms/Scalar/BoundsChecking.cpp test/Transforms/BoundsChecking/many-trap.ll

[Nuno Lopes]

Author: nlopes
Date: Thu May 31 17:58:48 2012
New Revision: 157777

URL: http://llvm.org/viewvc/llvm-project?rev=157777&view=rev
Log:
add -bounds-checking-multiple-traps option to make one trap BB per check
disabled by default for now; we can discusse the default value (& name) later

Added:
    llvm/trunk/test/Transforms/BoundsChecking/many-trap.ll
Modified:
    llvm/trunk/lib/Transforms/Scalar/BoundsChecking.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/BoundsChecking.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/BoundsChecking.cpp?rev=157777&r1=157776&r2=157777&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/BoundsChecking.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/BoundsChecking.cpp Thu May 31 17:58:48 2012
@@ -20,6 +20,7 @@
 #include "llvm/Analysis/ScalarEvolution.h"
 #include "llvm/Analysis/ScalarEvolutionExpander.h"
 #include "llvm/Analysis/ScalarEvolutionExpressions.h"
+#include "llvm/Support/CommandLine.h"
 #include "llvm/Support/Debug.h"
 #include "llvm/Support/InstIterator.h"
 #include "llvm/Support/IRBuilder.h"
@@ -35,6 +36,9 @@
 #include "llvm/Pass.h"
 using namespace llvm;
 
+static cl::opt<bool> ManyTrapBB("bounds-checking-multiple-traps",
+                                cl::desc("Use one trap block per assertion"));
+
 STATISTIC(ChecksAdded, "Bounds checks added");
 STATISTIC(ChecksSkipped, "Bounds checks skipped");
 STATISTIC(ChecksUnable, "Bounds checks unable to add");
@@ -98,7 +102,7 @@
 /// getTrapBB - create a basic block that traps. All overflowing conditions
 /// branch to this block. There's only one trap block per function.
 BasicBlock *BoundsChecking::getTrapBB() {
-  if (TrapBB)
+  if (TrapBB && !ManyTrapBB)
     return TrapBB;
 
   BasicBlock::iterator PrevInsertPoint = Builder->GetInsertPoint();

Added: llvm/trunk/test/Transforms/BoundsChecking/many-trap.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/BoundsChecking/many-trap.ll?rev=157777&view=auto
==============================================================================
--- llvm/trunk/test/Transforms/BoundsChecking/many-trap.ll (added)
+++ llvm/trunk/test/Transforms/BoundsChecking/many-trap.ll Thu May 31 17:58:48 2012
@@ -0,0 +1,12 @@
+; RUN: opt < %s -bounds-checking -bounds-checking-multiple-traps -S | FileCheck %s
+target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
+
+; CHECK: @f1
+define void @f1(i64 %x) nounwind {
+  %1 = alloca i128, i64 %x
+  %2 = load i128* %1, align 4
+  %3 = load i128* %1, align 4
+  ret void
+; CHECK: llvm.trap
+; CHECK: llvm.trap
+}