[llvm-commits] [compiler-rt] r157742 - in /compiler-rt/trunk/lib/asan/output_tests: large_func_test.cc null_deref.cc

[Alexander Potapenko]

Author: glider
Date: Thu May 31 08:55:40 2012
New Revision: 157742

URL: http://llvm.org/viewvc/llvm-project?rev=157742&view=rev
Log:
Fix the wildcards for two output tests on Darwin.

It turns out that atos does not print the symbol names for static C++ functions correctly (one of the two leading underscores is omitted), so they remain mangled.

Modified:
    compiler-rt/trunk/lib/asan/output_tests/large_func_test.cc
    compiler-rt/trunk/lib/asan/output_tests/null_deref.cc

Modified: compiler-rt/trunk/lib/asan/output_tests/large_func_test.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/output_tests/large_func_test.cc?rev=157742&r1=157741&r2=157742&view=diff
==============================================================================
--- compiler-rt/trunk/lib/asan/output_tests/large_func_test.cc (original)
+++ compiler-rt/trunk/lib/asan/output_tests/large_func_test.cc Thu May 31 08:55:40 2012
@@ -35,7 +35,12 @@
 // Check-Common: {{.*ERROR: AddressSanitizer heap-buffer-overflow on address}}
 // Check-Common:   {{0x.* at pc 0x.* bp 0x.* sp 0x.*}}
 // Check-Common: {{READ of size 4 at 0x.* thread T0}}
-// Check-Common: {{    #0 0x.* in LargeFunction.*large_func_test.cc:15}}
+
+// atos incorrectly extracts the symbol name for the static functions on
+// Darwin.
+// Check-Linux:  {{    #0 0x.* in LargeFunction.*large_func_test.cc:15}}
+// Check-Darwin: {{    #0 0x.* in .*LargeFunction.*large_func_test.cc:15}}
+
 // Check-Common: {{    #1 0x.* in main .*large_func_test.cc:3[012]}}
 // Check-Common: {{0x.* is located 44 bytes to the right of 400-byte region}}
 // Check-Common: {{allocated by thread T0 here:}}

Modified: compiler-rt/trunk/lib/asan/output_tests/null_deref.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/output_tests/null_deref.cc?rev=157742&r1=157741&r2=157742&view=diff
==============================================================================
--- compiler-rt/trunk/lib/asan/output_tests/null_deref.cc (original)
+++ compiler-rt/trunk/lib/asan/output_tests/null_deref.cc Thu May 31 08:55:40 2012
@@ -10,8 +10,9 @@
 // Check-Common:   {{0x0*00028 .*pc 0x.*}}
 // Check-Common: {{AddressSanitizer can not provide additional info. ABORTING}}
 
-// atos on Mac cannot resolve the file:line info for frame 0 on the O1 level
+// atos on Mac cannot resolve the file:line info for frame 0 on the O1 level.
+// It also can't extract the symbol name correctly.
 // Check-Linux: {{    #0 0x.* in NullDeref.*null_deref.cc:3}}
-// Check-Darwin: {{    #0 0x.* in NullDeref.*}}
+// Check-Darwin: {{    #0 0x.* in .*NullDeref.*}}
 
 // Check-Common: {{    #1 0x.* in main.*null_deref.cc:[67]}}